Skip to content

Update LilyGo variants and add new variants #11192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 28, 2025
Merged

Update LilyGo variants and add new variants #11192

merged 6 commits into from
Mar 28, 2025

Conversation

lewisxhe
Copy link
Contributor

  1. Add some macro definitions and variant version selections for two existing products (T-Watch-S3, T-Watch-Ultra).
  2. Add a new variant (LilyGo-T-LoRa-Pager)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2025 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Added variant LilyGo-T-LoRa-Pager":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update LilyGo T-Watch-S3 definition and expansion options":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update LilyGo T-Watch-Ultra definition and expand options":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update LilyGo board partition table order":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update partition table order":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello lewisxhe, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 1292b07

@P-R-O-C-H-Y
Copy link
Member

Just a small nit-pick. Otherwise its looking good :)

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Mar 28, 2025
@me-no-dev me-no-dev merged commit de184bd into espressif:master Mar 28, 2025
11 checks passed
@lyusupov
Copy link
Contributor

lyusupov commented Mar 28, 2025 •
edited
Loading

@lewisxhe

0x82D1 is already occupied by another device...

image

would you mind to switch on 0x82D4 ?

image

@lewisxhe
Copy link
Contributor Author

Oh! Sorry. I forgot to change it. Thanks for reminding me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lewisxhe @P-R-O-C-H-Y @lyusupov @me-no-dev